fix: Search systems and deployments #353

adityachoudhari26 · 2025-03-02T03:58:38Z

Summary by CodeRabbit

New Features
- Introduced a new component for displaying a list of systems within a workspace, featuring search and filter functionality.
- Added options for creating new systems and deployments directly from the systems page.
Refactor
- Streamlined the rendering logic by offloading responsibilities to the new SystemsPageContent component.
- Simplified data handling in the SystemDeploymentTable by directly accessing pre-fetched data.
Style
- Updated table styling for a cleaner appearance with rounded corners.

coderabbitai · 2025-03-02T03:58:46Z

Caution

Review failed

The pull request is closed.

Walkthrough

A new React component, SystemsPageContent, has been introduced to render a list of systems for a workspace, utilizing React hooks for state and URL management. The rendering logic has been refactored from the SystemsPage component to this new component. Several deployment table components have been updated to accept a new systemSlug prop and to use types imported from a unified schema module (SCHEMA), enhancing type handling. Additionally, the API query logic in the system router has been improved to support more comprehensive filtering through left joins and multiple field matches.

Changes

File(s)	Change Summary
`apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/SystemsPageContent.tsx` `apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/page.tsx`	Introduced `SystemsPageContent` component for displaying systems; refactored `SystemsPage` to delegate rendering to this new component by passing the workspace object.
`apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/(sidebar)/deployments/TableDeployments.tsx`	Added new `systemSlug` prop to the `LazyDeploymentEnvironmentCell` component to expand its data context.
`apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/_components/deployments/.../DeploymentEnvironmentCell.tsx`	Updated type definitions to use `SCHEMA` types and added a `systemSlug` prop; modified URL construction to utilize the new prop.
`apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx` `.../SystemDeploymentSkeleton.tsx` `.../TableDeployments.tsx`	Refactored the system deployment table components: replaced direct `RouterOutputs` type imports with `SCHEMA`, introduced an extended System type with deployments and environments, removed conditional loading state logic, and updated styling (added `rounded-md` class) in skeleton components.
`packages/api/src/router/system.ts`	Enhanced system query logic with a more complex filter condition: added an `or` condition across system and deployment fields, incorporated a left join with the deployment table, and simplified the total count query.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SPC as SystemsPageContent
    participant C as useSystemFilter Hook
    participant Q as API Query Hook
    participant API as System Router API
    participant T as SystemDeploymentTable

    U->>SPC: Enter search query
    SPC->>C: Update and sync filter state
    C-->>SPC: URL parameter updated
    SPC->>Q: Trigger systems list query with filter
    Q->>API: Request systems (with deployments & environments)
    API-->>Q: Return filtered systems data
    Q-->>SPC: Provide systems data
    SPC->>T: Render data in system deployment table

Possibly related PRs

fix: Add skeletons on systems page #351: Introduced skeleton loading states for systems page components, aligning with UI enhancements and modular rendering changes in the current PR.

Suggested reviewers

jsbroks

Poem

In fields of code where systems sprout,
My little paws hop all about.
New hooks and schemas, sleek and bright,
I nibble bugs from morn till night.
With joyful leaps through lines so clear,
CodeRabbit sings—let’s cheer and cheer!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26d447f and 3a6f905.

📒 Files selected for processing (1)

packages/api/src/router/system.ts (3 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jsbroks · 2025-03-02T05:02:46Z

packages/api/src/router/system.ts

-      );
+      const query = input.query
+        ? or(
+            like(system.name, `%${input.query}%`),


ilike, can we use similarity? Or the logic we uses for the default search

fix: Search systems and deployments

26d447f

jsbroks reviewed Mar 2, 2025

View reviewed changes

use ilike

3a6f905

adityachoudhari26 merged commit 2d3cbc4 into main Mar 2, 2025
4 of 6 checks passed

adityachoudhari26 deleted the system-page-search branch March 2, 2025 06:13

This was referenced Mar 2, 2025

fix: Limit applies to systems only, not joined deployment and environment rows #355

Merged

fix: System deployments folder view #358

Merged

coderabbitai bot mentioned this pull request Mar 31, 2025

fix: Search and pagination on envs list #434

Merged

coderabbitai bot mentioned this pull request May 1, 2025

refactor: system table cell uses new jobs #533

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Search systems and deployments #353

fix: Search systems and deployments #353

Uh oh!

adityachoudhari26 commented Mar 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 2, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

jsbroks Mar 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Search systems and deployments #353

fix: Search systems and deployments #353

Uh oh!

Conversation

adityachoudhari26 commented Mar 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

jsbroks Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adityachoudhari26 commented Mar 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 2, 2025 •

edited

Loading